kaxil commented on code in PR #70229:
URL: https://github.com/apache/airflow/pull/70229#discussion_r3680879578


##########
providers/common/ai/src/airflow/providers/common/ai/policies/retry.py:
##########
@@ -109,12 +133,15 @@ def __init__(
         instructions: str | None = None,
         fallback_rules: list[RetryRule] | None = None,
         timeout: float = 30.0,
+        *,
+        redact_exception: bool = True,

Review Comment:
   `providers/common/ai/docs/retry_policies.rst` isn't updated here: the 
Parameters table lists the five existing constructor args but not 
`redact_exception`, and "How it works" step 1 still reads "Sends the exception 
message to the configured LLM". The "Local LLM support" section right below 
that table is framed as the mitigation for "environments where exception data 
must not leave the infrastructure", which now understates the default 
behaviour. Once the page carries that guidance, the 15-line `.. warning::` 
block here could shrink to a pointer rather than restating the `:param 
redact_exception:` text.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to