potiuk commented on PR #70621: URL: https://github.com/apache/airflow/pull/70621#issuecomment-5129705245
Thanks for this — the change is correct and the diagnosis is right: these three deprecation warnings were firing against un-rendered template values in `__init__`. Unfortunately it duplicates #70449, which makes the same change to the same file and was opened on 25 July, three days before this one. Airflow does allow parallel work on the same problem — "better PR wins" — but the convention is to check for an existing PR first and build on it rather than open a second one, precisely to avoid two people doing the same work. Comparing the two honestly: #70449 extracts the warnings into a named `_warn_on_deprecated_template_fields()` helper rather than inlining them in `execute`, and it adds a test that builds a real DAG and asserts the warning fires on the **rendered** value — which is the actual behaviour being fixed. This PR adapts the existing tests to call `execute` but doesn't pin the rendered-value contract. On that basis I'm going with #70449, and I'm closing this one. Genuinely though — the analysis here was sound. If you want to stay involved, a review on #70449 would be welcome, and there are still several operators listed in `scripts/ci/prek/validate_operators_init_exemptions.txt` waiting for exactly this treatment if you'd like to pick an unclaimed one. --- Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
