potiuk commented on PR #70656:
URL: https://github.com/apache/airflow/pull/70656#issuecomment-5130293473
Thanks — your diagnosis is right, and the fix is correct: `args = {command,
powershell, cmdlet}` built a set (collapsing equal values) and `exactly_one`
counted truthiness rather than presence, so the `is not None` rewrite is the
proper correction.
It duplicates #70347 though, which makes the identical change to the same
two files and was opened on 23 July, six days before this one. That PR also
carries the fix through `execute()` and removes the operator from
`validate_operators_init_exemptions.txt`, so it's the more complete version —
I'm closing this in its favour and have asked there for the one extra
behavioural change it contains to be split out or documented.
One unrelated observation while I'm here: this PR also touches
`scripts/in_container/run_generate_constraints.py`, which doesn't appear
connected to the PsrpOperator fix. If that was an accidental inclusion it's
worth checking your branch; if it's a real fix it deserves its own PR where
it'll actually get reviewed rather than riding along unnoticed.
Worth a quick `gh pr list --search "<operator>"` before starting on one of
these — several of the `validate_operators_init_exemptions.txt` entries have
had two people working on them independently this week.
---
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
