Lee-W commented on code in PR #68997:
URL: https://github.com/apache/airflow/pull/68997#discussion_r3690427500
##########
providers/standard/src/airflow/providers/standard/sensors/external_task.py:
##########
@@ -191,10 +193,19 @@ def __init__(
execution_delta: datetime.timedelta | None = None,
execution_date_fn: Callable | None = None,
check_existence: bool = False,
- poll_interval: float = 2.0,
+ poll_interval: datetime.timedelta | float | None = None,
Review Comment:
I don't completely agree that `poll_interval` is an alias for
`poke_interval`. Based on my reading, `poke_interval` supports more types than
the original `poll_interval`, so it feels more like a superset than an alias.
That said, the difference is subtle, so this is non-blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
