Ei-Sandi opened a new pull request, #70838:
URL: https://github.com/apache/airflow/pull/70838
## Description
Follow-up to #68906, which added a single `dag.serialization_writes` counter
emitted from two different branches of `SerializedDagModel.write_dag`. Sharing
one name means the metric can't distinguish the two ways a Dag gets serialized,
and they have very different consequences:
- a new `DagVersion` row is inserted — unbounded growth across
`dag_version`, `dag_code` and `serialized_dag`
- the latest `DagVersion` is overwritten in place — bounded churn on a
single row
A Dag that re-serializes on every parse (for example one whose template
holds a callable, with no actual change to the Dag) shows up in either path
depending on whether its current version has task instances, but only the first
grows the metadata DB. Splitting the counter lets the two be alerted on with
different thresholds.
`dag.serialization_writes` is replaced by:
| metric | emitted when |
|---|---|
| `dag.serialization.version_created` | a new Dag version is written — first
serialization, or the latest version already has task instances |
| `dag.serialization.version_updated` | the latest Dag version is
overwritten in place, having no task instances |
The metric has not been released yet, so there is no deprecation path and no
newsfragment.
The paths that write no serialized data — a bundle-metadata refresh, or a
parse where nothing changed — are still uncounted.
related: #68906
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (please specify the tool below)
Co-authored-by: [Claude Opus 5] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
