Miretpl commented on code in PR #70228:
URL: https://github.com/apache/airflow/pull/70228#discussion_r3693644381
##########
providers/celery/tests/unit/celery/executors/test_celery_executor.py:
##########
@@ -724,15 +724,24 @@ def
test_celery_executor_with_no_recommended_result_backend(caplog):
) in caplog.text
-@conf_vars({("celery_broker_transport_options", "sentinel_kwargs"):
'{"service_name": "mymaster"}'})
-def test_sentinel_kwargs_loaded_from_string():
[email protected](
+ (
+ "option",
+ "value",
+ "expected",
+ ),
+ [
+ ("sentinel_kwargs", '{"service_name": "mymaster"}', {"service_name":
"mymaster"}),
+ ("kafka_common_config", '{"compression.type": "zstd"}',
{"compression.type": "zstd"}),
Review Comment:
Could you test any option which is valid for the parsing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
