mitre88 commented on code in PR #70534:
URL: https://github.com/apache/airflow/pull/70534#discussion_r3693700299
##########
providers/google/src/airflow/providers/google/firebase/operators/firestore.py:
##########
@@ -78,14 +77,14 @@ def __init__(
self.project_id = project_id
self.gcp_conn_id = gcp_conn_id
self.api_version = api_version
- self._validate_inputs()
Review Comment:
@kaxil Because `body` is a template field, so `if not self.body` in
`__init__` reads the *unrendered* value: a Jinja template string like `"{{
ti.xcom_pull(...) }}"` is always truthy at construction time, so the check can
never catch a body that renders empty — and per the template-field validation
burn-down (#70296), value checks on templated parameters belong after
rendering. Moving the call to `execute()` validates the rendered value. (An
argument-*provision* check would stay in `__init__` per #70505, but `not
self.body` is a truthiness/value check, which is exactly the kind that must
move.)
Same rationale for the `speech_to_text`/`text_to_speech` changes in this PR.
---
Drafted-by: Claude Code (Fable 5) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
