Vamsi-klu commented on code in PR #67764:
URL: https://github.com/apache/airflow/pull/67764#discussion_r3694620336
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -1980,8 +1980,11 @@ def _do_scheduling(self, session: Session) -> int:
"""
# Put a check in place to make sure we don't commit unexpectedly
with prohibit_commit(session) as guard:
- if self._scheduler_use_job_schedule:
- self._create_dagruns_for_dags(guard, session)
+ # ``[scheduler] use_job_schedule`` disables only cron/time-based
scheduling. Asset- and
+ # partitioned-asset-triggered runs must still be created, so
always run the orchestrator
+ # here; the flag is applied inside ``_create_dagruns_for_dags``
where it gates only the
+ # time-based creation.
Review Comment:
Fair point, trimmed. Dropped the comment at `_do_scheduling` entirely and
kept a single line at the actual gate. No behavior change, the three regression
tests still pass.
---
Drafted-by: Claude Code (Fable 5); reviewed by @Vamsi-klu before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
