Dev-iL commented on code in PR #70619:
URL: https://github.com/apache/airflow/pull/70619#discussion_r3694730930
##########
providers/amazon/docs/executors/general.rst:
##########
@@ -312,6 +312,21 @@ You will be prompted to enter the password if the
connection is successful.
.. END DATABASE_CONNECTION
+.. BEGIN SQL_ALCHEMY_CONN
+
+.. code-block:: bash
+
+ postgresql+psycopg2://<username>:<password>@<endpoint>/<database_name>
+
+.. note::
+ ``psycopg2`` works on every Airflow version these executors support. From
Airflow 3.2.0 you may use
+ ``postgresql+psycopg://`` instead, provided psycopg3 is installed. Airflow
before 3.2.0 does not
Review Comment:
```suggestion
``postgresql+psycopg://`` instead, provided ``psycopg`` (v3) is
installed. Airflow before 3.2.0 does not
```
I think it's better not to use `psycopg3` because this is not what users
need to pip-install (the pypi entry looks like a placeholder last updated in
2013).
I think we can only mention "(v3)" the first time psycopg is mentioned in
the document, no need to add that everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
