potiuk commented on PR #70791: URL: https://github.com/apache/airflow/pull/70791#issuecomment-5151244169
Thanks @shahar1 — both correct, both fixed. - **Rationale comments** added above every one of the 45 specifiers, across all 15 files, with the tracking pointer as a full URL so it resolves from a grep of a checkout. There is no tracking *issue* for pandas 3 support, so the comments point at #70558, which is the PR that removes the cap — that seemed more useful than opening an issue whose only content would be "see that PR". Say the word if you would rather have a real issue. - **`test_pandas_2_dataframe_xcom_still_round_trips` dropped.** You were right that it passes unchanged on `main` — nothing read `pd.__version__` before this PR, so monkeypatching it to a 2.x value while the installed pandas is already 2.x asserted nothing, and `test_pandas_serializers` already covers the round trip. That is the second vacuous test of mine you have caught in this batch, which is a useful signal about how I was writing them: I was checking that the new code path *is reachable* rather than that the new behaviour *is required*. The reverting-the-change test is the right bar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
