potiuk commented on PR #70802: URL: https://github.com/apache/airflow/pull/70802#issuecomment-5151459029
Thanks — this is a close call, and sorry to close it. Three PRs independently fixed this bug; I am going with #69885, open since 14 July. Yours is good work and better in two respects: the docstring actually explains *why* a caller with a custom base dir must pass it, and you linked the originating issue #69813. #69885 has the edge on coverage though — it pins the rejection case on Windows as well as POSIX, whereas this covers the negative path for POSIX only. On a validation guard the refusals are the part most worth locking down. Also worth knowing: #70091 has since rewritten these same command builders on `main` to use `shlex.quote`, so all three branches conflicted. I resolved that on #69885 rather than sending it back. I would rather not lose your docstring — if you would like to carry it and the issue link over as a follow-up once #69885 lands, that would genuinely improve the result. --- Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
