jason810496 opened a new pull request, #70918:
URL: https://github.com/apache/airflow/pull/70918

   ## Why
   
   In plugin mode, `bundlev1server` installs an slog default logger that 
forwards through an `hclog.Logger` so the go-plugin host can parse the plugin's 
stderr. That bridge came from the external `github.com/evanphx/go-hclog-slog` 
module, which ships **no license file and no tagged release** (it is pinned to 
a bare commit). That makes it awkward to depend on and to reason about.
   
   The adapter is small and we already maintain its mirror image in-tree — 
`pkg/logging/shclog` presents an slog Logger *as* an hclog. This adds the 
inverse and drops the external module.
   
   ## What
   
   - Add `pkg/logging/hclogslog`: a small `slog.Handler` that forwards records 
to an `hclog.Logger`, translating levels and flattening grouped attributes with 
dotted keys (100% unit-test covered).
   - Point `bundlev1server` at the in-tree package (the call site — 
`hclogslog.Adapt(hcLogger)` — is unchanged).
   - `go mod tidy` drops `github.com/evanphx/go-hclog-slog` from 
`go-sdk/go.mod` / `go-sdk/go.sum`; re-tidy 
`kubernetes-tests/lang_sdk/go_example` to drop its stale indirect entry.
   
   Plugin logging behaviour is identical.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 4.8)
   
   Generated-by: Claude Code (Opus 4.8) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to