Aaryan123456679 commented on PR #70243: URL: https://github.com/apache/airflow/pull/70243#issuecomment-5153138662
Pushed a follow-up commit that switches the Edit User view to override `edit.html`'s `edit_form` block instead of copying `form_vertical.html`, so the Reset Password action now renders outside the model's `<form>` — no more nested forms. `CustomUserDBModelView.edit()` now passes `actions`/`pk`/`modelview_name` directly to `render_template` instead of reaching into widget internals, and the `UserEditFormWidget` subclass is gone. Also corrected the PR description: the new template extends FAB's `edit.html` (it's a genuine override now, not a copy), and I reworded the "mirrors `show()`" note — `show()` removes entries FAB already populated, this adds one FAB never populates, and the safety here comes from `render_action_links`' own permission filter rather than symmetry with `show()`. Existing tests (`test_user_edit_view_shows_reset_password_action_with_access`, `test_user_edit_view_hides_reset_password_action_without_access`) needed no changes since they assert on rendered output, not widget/template internals — reran the full file (28 tests) and it passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
