Eason09053360 opened a new pull request, #70935:
URL: https://github.com/apache/airflow/pull/70935
## The method promised latest-version dags in its name and docstring but
read every serialized_dag row, so FAB permission syncing processed each Dag
once per version and could apply an outdated access_control last.
`DBDagBag.iter_all_latest_version_dags` promises latest-version Dags in
both its
name and its docstring, but it read every `serialized_dag` row without
filtering
by version.
Its only production caller is FAB's `create_dag_specific_permissions`, so
DAG-level
permission syncing iterated each Dag once per version. Besides the wasted
work, the
query has no `ORDER BY`, so when versions carry different `access_control`
the one
applied last is undefined and an outdated policy can win.
`SerializedDagModel._latest_by_version_select()` already supported "all
dags" via
`dag_ids=None`; this exposes that through the public
`get_latest_serialized_dags()`
wrapper, which keeps the existing `load_op_links` hook in the loop intact.
All five
existing callers pass `dag_ids=` explicitly, so the signature change is
backwards
compatible.
The existing test mocked `session.scalars`, so it could not catch a wrong
query.
Added a regression test that writes two real versions to the database.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 5)
Generated-by: Claude Code (Opus 5) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
