hkc-8010 commented on PR #69523:
URL: https://github.com/apache/airflow/pull/69523#issuecomment-5159736201

   @kaxil addressed in `da59ecaea6`.
   
   - moved the post-kill socket cleanup into task-sdk / 
`DagFileProcessorProcess.close()`, so core now just does `kill(...); close()`
   - `cleanup_sockets_after_kill()` drains only `stdout` / `stderr` / `logs`; 
`requests` is only unregistered/closed, so buffered request frames are no 
longer dispatched after SIGKILL
   - pulled the closed-handle suppression into a shared helper used by both 
structured log processing and `forward_to_log()`
   - broadened the guard to `"closed file" in str(e)` and added a debug 
breadcrumb when a line is dropped
   
   Added focused regressions for the no-request-dispatch path and both 
closed-file `ValueError` variants. `prek run --from-ref upstream/main --to-ref 
HEAD` also passed locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to