tooptoop4 commented on a change in pull request #6954: [AIRFLOW-4355] removed 
task should not lead to dagrun success
URL: https://github.com/apache/airflow/pull/6954#discussion_r363518094
 
 

 ##########
 File path: airflow/models/dag.py
 ##########
 @@ -549,6 +549,11 @@ def tasks(self, val):
     def task_ids(self):
         return list(self.task_dict.keys())
 
+    @property
+    def active_tasks(self):
+        """Return tasks in a DAG. Needed as part of determining overall DagRun 
outcome"""
+        return [t for t in self.tasks]
 
 Review comment:
   my understanding is Dag model has a static list of tasks that does not 
change, but dagrun could have a variable number of tasks due to db connectivity 
issues (ie REMOVED state) leading to potentially less tasks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to