Lee-W commented on code in PR #70497:
URL: https://github.com/apache/airflow/pull/70497#discussion_r3701830298
##########
airflow-core/src/airflow/provider.yaml.schema.json:
##########
@@ -447,6 +447,14 @@
},
"additionalProperties": false
},
+ "external-integrations": {
Review Comment:
It doesn't feel like `upstream` to me so I choose the term
`external-services` instead. Also documneted it in
`contributing-docs/23_provider_hook_migration_to_yaml.rst`.
##########
dev/registry/registry_contract_models.py:
##########
@@ -52,6 +52,7 @@ class ConnectionTypeContract(BaseModel):
conn_type: str
hook_class: str = ""
docs_url: str | None = None
+ external_integrations: list[str] = Field(default_factory=list)
Review Comment:
Added the test cases to `test_registry_contract_models.py`. It validates
`external_services`. If provided, the value should be there. If not, no error
should be raised.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
