Lee-W commented on code in PR #70498:
URL: https://github.com/apache/airflow/pull/70498#discussion_r3702048688
##########
registry/src/providers.njk:
##########
@@ -68,7 +68,8 @@ mainClass: providers-page
data-name="{{ provider.name | lower }}"
data-downloads="{{ provider.pypi_downloads.monthly }}"
data-updated="{{ provider.last_updated or '' }}"
- data-categories="{{ cats | join(',') }}">
+ data-categories="{{ cats | join(',') }}"
+ data-integrations="{{ (provider.categories or []) |
selectattr('name') | join(',', 'name') | lower }}">
Review Comment:
`data-id` is on the `<li>` and `matchesSearch` tests it, and the Pagefind
record now carries the id too.
I index `provider.id` instead of distribution name, and drop the shared
prefix off the query instead. Matching the distribution name directly makes
`apache` go from 18 cards to all 105, `airflow` from 2 to 105 and `providers`
from 0 to 105, since every provider's name starts with
`apache-airflow-providers-`.
Sweeping all 105 names, ids and distribution names plus every integration
name: nothing previously findable is lost, and queries that returned nothing
drop from 114 to 2 (`providers`, and the bare prefix with no trailing separator
— both already returned nothing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
