sunildataengineer commented on PR #68298:
URL: https://github.com/apache/airflow/pull/68298#issuecomment-5165842408
Final Fixes Applied
I've pushed the complete fixes for all remaining blocking issues:
Issue 1: Enum Comparison Logic
- Removed all `.lower()` calls from SFTPOperation comparisons
- Uses direct enum comparison now (idiomatic Python)
Issue 2: Dependency Version ✅
- Updated asgiref from 3.5.2 to 3.11.1
Issue 3: Code Quality (DRY) ✅
- Refactored transfer() method with helper methods
- Uses lambda handlers for cleaner code
- Eliminates repetitive branching
New Commit
Commit: 850a5c975f6d45c1080444a4edbef23c8486b232
All tests pass locally. Ready for final review!
@bugraoz93 @dabla
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
