potiuk commented on PR #70685: URL: https://github.com/apache/airflow/pull/70685#issuecomment-5173211150
The diff has changed materially since both of your reviews, so flagging for a fresh look rather than letting the existing approval carry it. @amoghrajesh — your approval predates @kaxil's review. Since then: - the traceback now travels in `next_kwargs` via `format_exception`, the way `submit_failure` already does it, because that is the only channel that reaches the task log; - decoding and re-encoding are separate `try` blocks with distinct messages, so a payload the trigger just yielded is no longer reported as unreadable stored kwargs; - the docstrings now say this runs in the triggerer too, and record why the `except` has to stay broad; - the shadowing local `TaskInstanceState` import is gone; - the `AWAITING_INPUT` sweep counts a task it could not resume separately rather than reporting it as resolved, and the test asserts `(1, 0, 1)`. @kaxil — the one finding I did not implement is the HITL write-side validation. It is filed as #71036 and linked from a comment on `handle_event_submit`; the reasoning is in that thread. Everything else is addressed above. None of this is a trivial rewording, so I would rather both of you look again before it goes in. --- Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
