uranusjr commented on code in PR #71057:
URL: https://github.com/apache/airflow/pull/71057#discussion_r3711149792


##########
airflow-core/docs/authoring-and-scheduling/language-sdks/java.rst:
##########
@@ -82,31 +82,36 @@ Java implementation
 
     import org.apache.airflow.sdk.*;
 
-    @Builder.Dag(id = "sales_pipeline")
+    @Dag(dagId = "sales_pipeline")

Review Comment:
   I prefer to keep the original naming
   
   * The interface uses Dag and Task
   * The Builder outer class (since the annotated class/method does not 
actually produce a dag/task)
   * The argument being `id`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to