Feudjo commented on code in PR #67244:
URL: https://github.com/apache/airflow/pull/67244#discussion_r3711175991
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -1554,9 +1554,15 @@ async def run_trigger(
event_stream = trigger.run()
async for event in event_stream:
- await self.log.ainfo(
- "Trigger fired event",
name=self.triggers[trigger_id]["name"], result=event
- )
+ # Avoid logging the full payload at INFO — it may contain
sensitive data and
+ # inflate log storage on every execution. DEBUG is used
instead so developers
+ # can still inspect the payload when needed without.
Review Comment:
Good point — I'll remove the is_enabled_for guard entirely. Since
result=event is just passing an existing variable with no expensive
computation. Removing the guard makes both the production code and the test
much simpler. Updated accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
