seanghaeli commented on code in PR #69988:
URL: https://github.com/apache/airflow/pull/69988#discussion_r3715583053
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -875,8 +875,10 @@ def _create_workload(
ti=ser_ti, # type: ignore
)
+ dag_run = trigger.task_instance.get_dagrun(session=session)
serialized_dag_model = dag_bag.get_serialized_dag_model(
- version_id=trigger.task_instance.dag_version_id,
+ version_id=DBDagBag._version_from_dag_run(dag_run=dag_run,
session=session)
+ or trigger.task_instance.dag_version_id,
session=session,
)
Review Comment:
In spirit I agree with what you suggest, but since there's already 3 reviews
I don't want to make any changes that nominally wouldn't change anything about
functionality.
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -875,8 +875,10 @@ def _create_workload(
ti=ser_ti, # type: ignore
)
+ dag_run = trigger.task_instance.get_dagrun(session=session)
serialized_dag_model = dag_bag.get_serialized_dag_model(
- version_id=trigger.task_instance.dag_version_id,
+ version_id=DBDagBag._version_from_dag_run(dag_run=dag_run,
session=session)
+ or trigger.task_instance.dag_version_id,
session=session,
)
Review Comment:
In spirit I agree with what you suggest, but since there's already 3
approvals I don't want to make any changes that nominally wouldn't change
anything about functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
