gtxu commented on code in PR #70960:
URL: https://github.com/apache/airflow/pull/70960#discussion_r3716120405
##########
providers/http/src/airflow/providers/http/hooks/http.py:
##########
@@ -218,6 +246,9 @@ def get_conn(
def _set_base_url(self, connection) -> None:
host = connection.host or self.default_host
schema = connection.schema or "http"
+ extra = connection.extra_dejson
+ self._srv_lookup_enabled = to_boolean(str(extra.get("srv_lookup",
False)))
+ self._srv_cache_ttl = float(extra.get("srv_cache_ttl",
self._srv_cache_ttl))
Review Comment:
I have poped the `srv_lookup` and `srv_cache_ttl` in
`_process_extra_options_from_connection` so they are consumed directly from
`extra_dejson` by the SRV lookup now. Also fix for async as they share the same
procedure.
Thank you for point it out!
Also add tests to validate whether extra options added here is string only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
