art22s commented on PR #71130: URL: https://github.com/apache/airflow/pull/71130#issuecomment-5187550919
Thanks for the review @Prab-27! Good points — I'll address both: 1. **Keep both dependencies**: Agreed, keeping `httpx` alongside `httpx2` in `task-sdk` is safer. Other packages (airflow-core, providers) still depend on `httpx`, so having both in `task-sdk` avoids any risk of breaking transitive resolution. 2. **Direct import instead of aliasing**: Fair point on type identity. The migration guide does recommend direct imports for better type checker and logger compatibility. I'll switch from `import httpx2 as httpx` to `import httpx2` and update the references accordingly. Pushing the changes shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
