SEPURI-SAI-KRISHNA commented on issue #71246: URL: https://github.com/apache/airflow/issues/71246#issuecomment-5208084620
Tested `google 22.3.0rc3` for [#70430](https://github.com/apache/airflow/pull/70430) (Fail deferred Cloud Composer tasks when the GCP operation errors) — works as expected. Installed the RC from PyPI into a clean venv (`apache-airflow-providers-google==22.3.0rc3`, resolved against `apache-airflow` 3.3.0) and verified against the installed artifact rather than a source checkout. **Unit tests** — the trigger tests ship green against the RC: ``` test_cloud_composer.py::TestCloudComposerExecutionTrigger::test_run_raises_when_operation_finished_with_error PASSED test_cloud_composer.py::TestCloudComposerExecutionTrigger::test_run_yields_event_when_operation_finished_without_error PASSED ... 6 passed ``` **Behavioural check with real LRO objects** — the unit tests use a stand-in, so I also exercised the trigger against actual `google.longrunning.operations_pb2.Operation` values: | Scenario | Result | |---|---| | `done=True` with `error.message` set | raises `AirflowException: Cloud Composer Environment error: quota exceeded` | | `done=True`, no error | yields `{'operation_name': ..., 'operation_done': True}` | | polls `done=False` twice, then fails | raises after polling | For contrast, the pre-fix loop on that same failed `Operation` returns `{'operation_name': 'op', 'operation_done': True}` — a success event for a failed operation, which is the bug. The RC no longer does this. I don't have a live Composer environment, so this is verification against the released artifact rather than a real environment creation/update failure. --- Drafted-by: Claude Code (Opus 5); reviewed by @SEPURI-SAI-KRISHNA before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
