radhwene commented on code in PR #68361:
URL: https://github.com/apache/airflow/pull/68361#discussion_r3731815051
##########
providers/google/src/airflow/providers/google/cloud/hooks/cloud_sql.py:
##########
@@ -346,10 +356,19 @@ def export_instance(self, instance: str, body: dict,
project_id: str):
return operation_name
@GoogleBaseHook.fallback_to_default_project_id
+ @GoogleBaseHook.operation_in_progress_retry()
Review Comment:
@henry3260 — this has been fixed since your review and the branch has moved
on twice since.
The submit now lives in `_submit_import`, which carries
`operation_in_progress_retry` on its
own. `_wait_for_operation_to_complete` runs outside that scope, in
`import_instance`, so a
retryable polling error fails the task instead of restarting the method
and re-submitting an
import the API already accepted.
`test_instance_import_does_not_resubmit_when_polling_fails`
locks it with `import_method.assert_called_once_with(...)`.
The PR is still blocked on the CHANGES_REQUESTED from this review. Could
you take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
