uranusjr commented on code in PR #58543: URL: https://github.com/apache/airflow/pull/58543#discussion_r3732295890
########## airflow-core/src/airflow/timetables/assets.py: ########## @@ -20,7 +20,10 @@ import typing from airflow.exceptions import AirflowTimetableInvalid -from airflow.serialization.definitions.assets import SerializedAsset, SerializedAssetBase +from airflow.sdk.definitions.asset import BaseAsset # TODO: Use serialized classes. Review Comment: This is a bad idea. I’d swap the isinstance check below to act on serialized objects, and default all unrecognized types to `ensure_serialized_asset` (and let that function blow up) instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
