uranusjr commented on code in PR #71072:
URL: https://github.com/apache/airflow/pull/71072#discussion_r3732889457
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -2247,13 +2256,55 @@ def _create_dagruns_for_partitioned_asset_dags(self,
session: Session) -> set[st
DagModel.is_stale.is_(False),
)
.order_by(AssetPartitionDagRun.created_at,
AssetPartitionDagRun.id)
- .limit(self._max_partition_dag_runs_per_loop),
+ .limit(self._max_partition_dag_runs_per_loop + 1),
of=AssetPartitionDagRun,
skip_locked=True,
key_share=False,
session=session,
)
).all()
+ has_backlog = len(rows) > self._max_partition_dag_runs_per_loop
+ pending_apdrs = rows[: self._max_partition_dag_runs_per_loop]
+ if has_backlog:
+ self.log.warning(
+ "Reached the per-tick cap on pending partitioned Dag runs; the
remaining backlog "
+ "will be evaluated over subsequent scheduler ticks",
+ cap=self._max_partition_dag_runs_per_loop,
+ pending_count=len(pending_apdrs),
+ )
+ # Edge-trigger the audit row: a persistent backlog re-hits this
branch every tick,
+ # and writing a `Log` row that often would flood the audit table.
Write it once per
+ # backlog episode; `_partition_cap_backlog_reported` is cleared
below once the
+ # backlog drains.
+ if not self._partition_cap_backlog_reported:
+ # A separate, independently-committed session is required
here: the caller
+ # (`_create_dagruns_for_dags`) runs under
`@retry_db_transaction`, which rolls
+ # back *session* on a `DBAPIError` — sharing that transaction
would silently
+ # discard this audit row along with the rest of the tick's
work.
+ # Invariant: this must run before *session* makes any writes
this tick, or the
+ # new connection's commit can lock-contend with it on SQLite.
+ try:
+ with create_session(scoped=False) as audit_session:
+ audit_session.add(
+ Log(
+ event="partition dag run cap reached",
+ extra=(
+ f"The scheduler evaluated
{len(pending_apdrs)} pending partitioned Dag "
+ f"runs this tick, reaching the internal
per-tick cap of "
+ f"{self._max_partition_dag_runs_per_loop}.
This cap is a hardcoded "
+ "scheduler safety limit, not a
configurable setting; the remaining "
+ "backlog will be evaluated over subsequent
ticks."
+ ),
+ )
Review Comment:
Should this log contain at least dag_id?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
