dsuhinin commented on PR #71235: URL: https://github.com/apache/airflow/pull/71235#issuecomment-5213456672
> I thought about your PRs again. > > First, if we do this, we should make these localStorage settings instead of deployment configs and they could go in Pierre's new settings page: [#70687](https://github.com/apache/airflow/pull/70687) > > Second, to preserve any links. Let's not mess with the Urls themselves but just redirect to a different page by default. > > Finally, being powered by the config isn't great when loading a brand new page when the config hasn't been fetched yet. The screen will have to show one page, and then start loading a different one. thank you for your feedback. yep, in case of [#70687](https://github.com/apache/airflow/pull/70687) I can re use this PR and just add more options. Probably in that case I can move: - https://github.com/apache/airflow/pull/71235 - https://github.com/apache/airflow/pull/70754 to be based on this PR and instead of `instance` config store everything in the same way in `localStorage`. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
