haseebmalik18 commented on code in PR #71054:
URL: https://github.com/apache/airflow/pull/71054#discussion_r3739561078
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py:
##########
@@ -80,6 +82,27 @@
log = structlog.get_logger(__name__)
+# Keys that ``serde.serialize`` refuses at any depth. A ``params_input``
carrying one could not be
Review Comment:
Good point, thanks! Only thing: XCom's validator raises `ValueError` so it
comes back as 422, but the issue asks for 400 here? This route already does its
option checks with `HTTPException(400)`, so I matched that. Would you still
want it at the datamodel layer even if it becomes 422?
I also kept the keys to just `__classname__`/`__id__` (what serialize
actually rejects) instead of the full `FORBIDDEN_XCOM_KEYS`, since the wider
set would reject valid things like `{"__version__": 1}`. Sound ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
