justinpakzad commented on PR #70453: URL: https://github.com/apache/airflow/pull/70453#issuecomment-5226186646
> Thanks for this — the rename is the right call, `get-by-alias` really did read as "get an asset by its alias". And `get-alias` pairs cleanly with the existing `list-aliases`. A few things: > > ### One thing left to update > After this rename, the only remaining `get-by-alias` occurrences in the repo are in airflow-core, and they weren't updated: > > * https://github.com/apache/airflow/blob/ef83892a357d3a3ada6bb0d192ab78f4dd2c1b18/airflow-core/src/airflow/cli/commands/asset_command.py#L110 > * https://github.com/apache/airflow/blob/ef83892a357d3a3ada6bb0d192ab78f4dd2c1b18/airflow-core/tests/unit/cli/commands/test_command_deprecations.py#L79 Thanks for the review Henry. Good call. I've updated the deprecation message and it's test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
