potiuk commented on code in PR #71104:
URL: https://github.com/apache/airflow/pull/71104#discussion_r3743189004
##########
airflow-core/src/airflow/provider.yaml.schema.json:
##########
@@ -557,12 +557,21 @@
"type": "array",
"description": "Decorators to use with the TaskFlow API. Can be
accessed by users via '@task.<name>'",
"items": {
- "name": {
- "type": "string"
+ "type": "object",
+ "properties": {
+ "name": {
+ "description": "Name the decorator is exposed under,
following '@task.'",
+ "type": "string"
+ },
+ "class-name": {
+ "description": "Class name that implements the
decorator",
+ "type": "string"
+ }
},
- "path": {
- "type": "string"
- }
+ "required": [
Review Comment:
Good call @kaxil The "additionalProperties" : false "locks" the API -
because we want to have providers install on past version of airflow. Those
checks are done on runtime, so it means that "additionalProperties" : true -
should only be used when we now **for sure** future version of the schema will
not add anything there.
But since you added it only in provider.yaml.schema.json - that's OK -
because it does not impact provider_info.schema.json - this is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
