yuseok89 commented on code in PR #70470: URL: https://github.com/apache/airflow/pull/70470#discussion_r3744222804
########## airflow-core/src/airflow/ui/src/pages/DagsList/DagsFilters/RunStateLookbackSelect.tsx: ########## @@ -0,0 +1,91 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { HStack, Text, type Select as ChakraSelect } from "@chakra-ui/react"; +import { createListCollection } from "@chakra-ui/react/collection"; +import { useTranslation } from "react-i18next"; +import { FiClock, FiZap } from "react-icons/fi"; + +import { Select } from "src/components/ui"; + +// "latest" matches on the latest run only; numeric values are hours; "any" has no time bound. +export type RunStateScope = "168" | "24" | "720" | "any" | "latest"; + +type Props = { + readonly dataTestId?: string; + readonly onChange: (value: RunStateScope) => void; + readonly triggerProps?: ChakraSelect.TriggerProps; + readonly value: RunStateScope; +}; + +const SCOPE_OPTIONS: ReadonlyArray<{ labelKey: string; value: RunStateScope }> = [ + { labelKey: "latestRun", value: "latest" }, + { labelKey: "last24Hours", value: "24" }, + { labelKey: "last7Days", value: "168" }, + { labelKey: "last30Days", value: "720" }, Review Comment: The time-range labels are now reused from the shared `common:timeRange` namespace. Making the ranges configurable is a nice idea. I was thinking it might be better as a separate follow-up rather than part of this PR. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
