uranusjr commented on code in PR #68048:
URL: https://github.com/apache/airflow/pull/68048#discussion_r3744777388
##########
providers/apache/spark/src/airflow/providers/apache/spark/hooks/spark_submit.py:
##########
@@ -1212,7 +1245,7 @@ def _poll_k8s_driver_via_api(self) -> str | None:
)
terminal_phase = phase
break
- if phase == "Failed":
+ if phase == "Failed" and not container_completed:
Review Comment:
The added clause means a pod in *Failed* whose driver exited 0 (e.g. an
Istio sidecar crashed) now falls through to line 1277 and returns *Succeeded*.
We should at least log a warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
