uranusjr commented on code in PR #69150: URL: https://github.com/apache/airflow/pull/69150#discussion_r3744866774
########## airflow-core/docs/howto/set-up-database.rst: ########## @@ -276,6 +276,13 @@ If you use a current Postgres user with custom search_path, search_path can be c For more information regarding setup of the PostgreSQL connection, see `PostgreSQL dialect <https://docs.sqlalchemy.org/en/20/dialects/postgresql.html>`__ in SQLAlchemy documentation. +.. note:: + + PostgreSQL connection strings can include multiple fallback hosts. Use SQLAlchemy's documented PostgreSQL + URL format for this setup so each fallback host is passed correctly to the selected PostgreSQL driver. See + `Specifying multiple fallback hosts <https://docs.sqlalchemy.org/en/20/dialects/postgresql.html#specifying-multiple-fallback-hosts>`__ + in the SQLAlchemy documentation. Review Comment: This generalizes "each fallback host is passed correctly to the selected PostgreSQL driver," but the linked anchor is scoped specifically to SQLAlchemy's psycopg2 dialect. Which scope does this actually affect? Note that we have recently changed the default to psycopg v3, so the difference in scope is significant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
