uranusjr commented on code in PR #71144:
URL: https://github.com/apache/airflow/pull/71144#discussion_r3748369878
##########
ts-sdk/example/src/main.ts:
##########
@@ -49,7 +49,7 @@ export async function readConnection({ client }:
TaskHandlerArgs) {
};
}
-registerTask({ dagId: DAG_ID, taskId: "build_message" }, buildMessage);
-registerTask({ dagId: DAG_ID, taskId: "read_connection" }, readConnection);
+dag.task("build_message", buildMessage);
+dag.task("read_connection", readConnection);
-await startCoordinator();
+await registerDags(dag);
Review Comment:
I’m not sure how I feel with a function named `registerDags` handling
sockets and a waiting server. Maybe use something more similar to the Java SDK
such as `serveDags()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
