pierrejeambrun opened a new pull request, #71368: URL: https://github.com/apache/airflow/pull/71368
The Dags list page hand-rolls its own filter row (`DagsFilters`) rather than going through the shared `FilterBar`, so the save/restore/pin-default views added in #68484 never reached it. Users reported that filters like status / run state / favorites / needs-review reset on every navigation away from `/dags` (issue #66933). `PresetFiltersMenu` already reads and writes `useSearchParams` and persists per `pathname` to `localStorage` — no FilterBar-specific plumbing. It drops into `DagsFilters` unchanged. Every Dags-page filter (`paused`, `favorite`, `last_dag_run_state`, `dag_run_state`, `needs_review`, `tags`, `tags_match_mode`, `teams`, `timetable_type`, `name_pattern`) is already a URL param, so a saved preset restores them faithfully; the table sort is captured by the same `tableSortKey(pathname)` side-channel `PresetFiltersMenu` already uses on other pages. The bookmark button lands at the far-right end of the `DagsFilters` HStack, mirroring where it sits on `FilterBar`-based pages. closes: #66933 <!-- Screenshots omitted: visual verification against a running dev server was blocked by local infra issues (react-syntax-highlighter@16 / refractor@5 ESM interop under vitest; dayjs.tz init order in `vite preview` on this workspace). The mounted component is identical to the `PresetFiltersMenu` that already ships on FilterBar pages via #68484, so the visual is unchanged — it just appears one more place. --> ##### Was generative AI tooling used to co-author this PR? - [X] Yes — Claude Code (Opus 4.7) Generated-by: Claude Code (Opus 4.7) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
