Pebble32 commented on PR #69705: URL: https://github.com/apache/airflow/pull/69705#issuecomment-5242584272
Explored it and it seems less intrusive than I first thought. The offset moves into `CronMixin` cleanly, and on the sdk side the fields are inherited by all cron timetables. The rest is mechanical, forwarding seed and max_jitter through the core constructors and the per class serialize, deserialize and encoder variants. For CronDataIntervalTimetable the shared offset shifts both interval bounds and the fire time by the same amount, so the window stays one full period long but sits offset from the cron line (00:35 to 00:35 instead of 00:00 to 00:00), and consecutive runs stay contiguous so no gaps or overlaps. I will go with that uniform shift as the default and document it, keeping the guidance to set max_jitter small relative to the period. Jittering only the fire time while keeping the interval on the cron boundary is possible but needs a targeted override, so I will leave it as a possible follow up. Will put up the CronMixin version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
