baha-bouali commented on issue #70265:
URL: https://github.com/apache/airflow/issues/70265#issuecomment-5246909005
Hey @jason810496!
I'd like to take on the **first follow-up task**, which is adding
deprecation warnings to the legacy
branches in `airflow_local_settings.py`.
Now that all 9 backends are merged, my proposed approach will be: a small
helper that emits `RemovedInAirflow4Warning` at the top of each of the 7 `elif
remote_base_log_folder.startswith(...)` branches (s3, cloudwatch, gs, wasb,
stackdriver, oss, hdfs)
2 things I'd like to confirm before making my PR:
1. Should the warning fire unconditionally whenever the branch executes
(simpler, message just
tells the user to check their provider version), or should it check the
installed provider
version via `importlib.metadata` and only warn if that version already
ships `from_config`
(avoids telling someone to "upgrade" when they're already on a new-enough
version and
something else is actually wrong)?
2. `elasticsearch`/`opensearch` are gated on
`ELASTICSEARCH_HOST`/`OPENSEARCH_HOST` rather than
URL scheme, so they don't fit this pattern the same way.
Thus, I'd propose covering just the 7
scheme-based backends here and leaving ES/OpenSearch for a separate
follow-up once their
dispatch design is settled, unless there's a preference for me to look at
those too.
Happy to open a draft PR once there's rough agreement on the above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
