Lee-W opened a new pull request, #71393:
URL: https://github.com/apache/airflow/pull/71393
The manual-trigger form's partition key field is empty for asset-driven
(PartitionedAssetTimetable) and partitioned_at_runtime Dags, since neither type
has a natural schedule tick to derive a value from. Submitting without a key
creates an unpartitioned run, which asset-driven downstream Dags can never
satisfy.
This adds a best-effort suggestion, tried in order: a pending
AssetPartitionDagRun already waiting on this Dag, a purely time-based guess
from the timetable's own asset partition mappers, and finally the partition key
of the most recent successful run. The suggestion only pre-fills the UI field;
validate_partition_key still accepts None, and users can edit or clear the
field before submitting.
The partitioned_at_runtime type's partition key field was also not rendered
at all in the trigger form, even though the backend already accepts a
partition_key for it; this fixes that visibility gap alongside the suggestion
feature.
Track 1 of the same issue (#71284) adds the same base class method
(Timetable.suggest_partition_key) and the same two DAGResponse fields
(suggested_partition_key, timetable_partitioned_at_runtime) for the Cron
timetable case, as a parallel, not-yet-merged PR. This PR temporarily
duplicates those declarations so it can be developed independently; once Track
1 merges, this PR should be rebased to drop the duplicated base class method
and API field declarations, keeping only the asset-driven and runtime-specific
fallback logic, resolver, and UI/tests.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
