ColtenOuO commented on PR #70132: URL: https://github.com/apache/airflow/pull/70132#issuecomment-5251398799
Thanks for catching this. I reproduced it myself and can confirm the output function re-invocation issue is real. The latest commit addresses everything from this round: - rehydrate_pydantic_output now unwraps ToolOutput/NativeOutput/PromptedOutput markers and gates on isinstance(x, type) instead of "did TypeAdapter raise" — an output function is never re-invoked during rehydrate. - dump_output_to_json's fallback now logs a warning instead of degrading silently. - Added tests covering marker unwrapping, the sequence-fallback case, and (most importantly) that an output function is never called during rehydrate. Ready for another pass whenever you have time, thanks again for the thorough review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
