bbovenzi commented on code in PR #71270:
URL: https://github.com/apache/airflow/pull/71270#discussion_r3760642811
##########
airflow-core/src/airflow/ui/src/components/renderStructuredLog.tsx:
##########
@@ -216,9 +218,9 @@ const renderStructuredLogImpl = ({
return "";
}
- if (Boolean(timestamp) && showTimestamp) {
+ if (timestamp !== undefined && Boolean(timestamp) && showTimestamp) {
if (renderingMode === "text") {
- elements.push(`[${timestamp}] `);
+ elements.push(`[${formatTimestamp?.(timestamp) ?? timestamp}] `);
Review Comment:
This can become `"" ?? timestamp` and won't always fallkback onto the raw
timestamp. Let's
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
