moomindani commented on code in PR #71374:
URL: https://github.com/apache/airflow/pull/71374#discussion_r3762863609
##########
providers/databricks/src/airflow/providers/databricks/operators/databricks.py:
##########
@@ -769,6 +777,7 @@ def __init__(
access_control_list: list[dict[str, str]] | None = None,
wait_for_termination: bool = True,
git_source: dict[str, str] | None = None,
+ performance_target: str | None = None,
Review Comment:
Non-blocking, but worth considering: the Databricks API does not validate
this value. I sent `performance_target: "BOGUS"` and the run was accepted,
silently resolving to `effective_performance_target: PERFORMANCE_OPTIMIZED` —
no error, no warning.
That means a typo or a lowercase `"standard"` leaves the user on the default
mode without any signal, which for this particular field means unexpected cost
characteristics rather than a visible failure. Since it is a two-value enum,
validating in `__init__` against `{"PERFORMANCE_OPTIMIZED", "STANDARD"}` would
surface the mistake at parse time.
Happy to leave it — the other named parameters do not validate either, and
this is API behaviour rather than anything this PR introduced. Flagging it
because silent cost impact is harder to notice than a failed task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
