amoghrajesh commented on code in PR #71211:
URL: https://github.com/apache/airflow/pull/71211#discussion_r3772644493
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/glue.py:
##########
@@ -158,6 +203,16 @@ def __init__(
),
**kwargs,
):
+ if resume_glue_job_on_retry is not None:
+ # Kept as a real named parameter (not **kwargs) so `default_args`
still applies correctly.
+ if AIRFLOW_V_3_3_PLUS:
Review Comment:
Following up since the design moved since this was marked resolved.
The warning still fires unconditionally on every version, that part has not
changed. I realised from user lens and `durable` set directly no longer does
anything at all below 3.3 (previously a functional drop-in, which was the
premise here, which didnt feel right because old users should not be aware of
this flag), only `resume_glue_job_on_retry` activates the old XCom/scan
mechanism there now.
So the message itself is version-aware, below 3.3 it says "On Airflow 3.3+,
use durable instead" instead of telling that user to switch to something
currently inert for them and glue.rst picked up the same nuance for the same
reason. The warning and its removal timeline (tied to the provider's minimum
Airflow version, not the caller's) still apply to every version, per your
original ask.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
