amoghrajesh opened a new pull request, #71531:
URL: https://github.com/apache/airflow/pull/71531
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
`durable` was left in `**kwargs` instead of being a named parameter on
`RedshiftDataOperator`, `LivyOperator`, `DatabricksSubmitRunOperator`,
`DatabricksRunNowOperator`, `BigQueryInsertJobOperator`, and
`SnowflakeSqlApiOperator`.
`_apply_defaults` only fills parameters that are literally named in a
decorated `__init__`, so `default_args={"durable": False}` silently left
`durable` at its mixin-owned default of `True` on every one of these operators.
Separately, none of these six operators ever read `self.durable` outside
their own compat stub's `__init__`, so the value has always been a genuine
no-op below Airflow 3.3 because there's no task state store for it to control.
But the stub accepted any value silently, with no signal that it did nothing.
Now it warns, below 3.3 emits `UserWarning: durable has no effect on Airflow
versions below 3.3.`, so nobody mistakes silence for effect.
None of these operators have a legacy flag to fall back on (unlike
Glue's `resume_glue_job_on_retry` or KPO's `reattach_on_restart`), so
there's nothing else to resolve -- the warning is the whole fix.
---
## Before / after: `durable` on Airflow below 3.3
Applies identically to all six operators (`RedshiftDataOperator`,
`LivyOperator`, `DatabricksSubmitRunOperator`, `DatabricksRunNowOperator`,
`BigQueryInsertJobOperator`, `SnowflakeSqlApiOperator`) — none of them have a
legacy flag, and none of them ever read `self.durable` outside their compat
stub, so **behavior never changes** here. Only the warning is new.
| `durable` passed | Behavior (before and after, unchanged) | Warning —
before | Warning — after |
|---|---|---|---|
| not set | operator always submits fresh, no task-state-store lookup (below
3.3 doesn't have one) | none | none |
| `True` | same — no effect | none | `UserWarning`: "`durable` has no effect
on Airflow versions below 3.3." |
| `False` | same — no effect | none | `UserWarning`: "`durable` has no
effect on Airflow versions below 3.3." |
| `default_args` | Before | After |
|---|---|---|
| `default_args={"durable": False}`, no explicit `durable` kwarg | ignored —
`durable` stayed at the mixin's default of `True` | reaches the operator
correctly — `durable` is `False` |
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
