jason810496 commented on code in PR #71057:
URL: https://github.com/apache/airflow/pull/71057#discussion_r3773420056
##########
kubernetes-tests/lang_sdk/java_example/src/java/org/apache/airflow/k8sexample/K8sBundleBuilder.java:
##########
@@ -26,6 +26,8 @@
// CombinedExampleBuilder is generated by the annotation processor from the
// @Builder.Dag class CombinedExample.
public class K8sBundleBuilder implements BundleBuilder {
+ // Dag, not DagDef: the k8s harness publishes the SDK from upstream main
while this example
+ // tracks the branch, so the rename can only be adopted here once it has
merged upstream.
@NotNull
@Override
public Iterable<Dag> getDags() {
Review Comment:
We will need https://github.com/apache/airflow/pull/71527 get merged first
then we can rebase and change the `Dag` to `DagRef`. I intentionally keep the
old syntax here to get k8s test pass, please see more detail in
https://github.com/apache/airflow/pull/71527.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
