amoghrajesh opened a new pull request, #71534:
URL: https://github.com/apache/airflow/pull/71534

    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
https://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   For user-facing UI changes, please attach before/after screenshots (or a 
short
   screen recording) so reviewers can assess the visual impact.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   `durable` was already wired straight into the operator's YARN cluster-mode 
validation and, before this, was silently accepted below 3.3 with no signal 
that it does nothing there since this provider still supports Airflow 2.11 
through 3.x and ResumableJobMixin (and the task state store it relies on) only 
exists on 3.3+.
   
   The compat stub now warns if durable is set explicitly below 3.3 and always 
resolves it to False, matching the same fix already applied to 
https://github.com/apache/airflow/pull/71531
   
   `reconnect_on_retry` -- the parameter's original name, introduced in the 
same PR as ResumableJobMixin itself and renamed to durable almost immediately 
-- gets a plain map-and-deprecate rather than the legacy-flag treatment Glue 
and KPO need. It was never a distinct pre-existing mechanism with its own 
below-3.3 behavior to preserve, so telling a caller on any version to "use 
durable instead" is not bad advice the way it would be for a flag with real 
legacy behavior. The
   deprecation warning fires on every Airflow version regardless, since removal 
happens on this provider's own release schedule, not the caller's.
   
   The YARN `yarn_track_via_rm_api` requirement needed no code change: it 
already reads `self.durable`, so once durable is properly inert below 3.3, the 
requirement naturally stops applying there too -- there's no durable-execution 
prerequisite to enforce when durable execution itself isn't active.
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to