ashb commented on code in PR #69748:
URL: https://github.com/apache/airflow/pull/69748#discussion_r3775383663
##########
providers/http/src/airflow/providers/http/operators/http.py:
##########
@@ -163,6 +167,18 @@ def hook(self) -> HttpHook:
def execute(self, context: Context) -> Any:
if self.deferrable:
+ # One advisory per task attempt (not per page / not on trigger
reconstruct).
+ # Deferrable mode runs the HTTP call in the Triggerer; a restart
can re-run it.
+ method = (self.method or "").upper()
+ if method not in IDEMPOTENT_METHODS:
+ self.log.warning(
Review Comment:
We should also provide a means for the user to silence this warning on a
per-task basis.
Additionally we should link to a page in the Airflow docs for the http
provider, not to a GH issue - so those docs need to be added to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
