Miretpl commented on code in PR #70238:
URL: https://github.com/apache/airflow/pull/70238#discussion_r3778790779
##########
chart/values.schema.json:
##########
@@ -10054,6 +10060,82 @@
}
},
"definitions": {
+ "AirflowPodSecurityContext": {
Review Comment:
Hmm, I think it was on the first iteration, was deleted after that, and
suddenly it came back. It is not used anywhere - could you delete it?
##########
chart/values.schema.json:
##########
@@ -126,6 +126,12 @@
"allowPrivilegeEscalation": false
}
]
+ },
+ "disableDefaults": {
+ "description": "If `true`, the chart will not set any
default `securityContext` values when `securityContexts.pod` /
`securityContexts.containers` (or the equivalent per-component overrides) are
left empty. (Default `false` is deprecated and will change to `true` in a
future release)",
Review Comment:
```suggestion
"description": "If `true`, the chart will not set any
default `securityContext` values when `securityContexts.pod` /
`securityContexts.containers` (or the equivalent per-component overrides) are
left empty (default `false` is deprecated and will change to `true` in a future
release).",
```
##########
chart/values.yaml:
##########
@@ -47,6 +47,11 @@ gid: 0
securityContexts:
pod: {}
containers: {}
+ # If `true`, the chart will not set any default `securityContext` values when
+ # `securityContexts.pod` / `securityContexts.containers` (or the equivalent
per-component
+ # overrides) are left empty. (Default `false` is deprecated and will change
to `true`
+ # in a future release)
Review Comment:
```suggestion
# overrides) are left empty (default `false` is deprecated and will change
to `true`
# in a future release).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
